----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review43009 -----------------------------------------------------------
Hey Dominic, what will these Gauge methods expose when: (1) A Master fails over. (2) All the slaves re-register w/ tasks. (3) The framework has not re-registered yet! (4) We hit the endpoint, this will say 0 tasks in each state right? We may want to loop over the slaves instead here. src/master/master.cpp <https://reviews.apache.org/r/21279/#comment76996> Shouldn't these be with the other gauge definitions, rather than below ~Metrics? src/master/master.cpp <https://reviews.apache.org/r/21279/#comment76997> Shouldn't these be with the other gauge definitions, rather than below ~Metrics? How about s/taskCount/count/ and s/++count/count++/ to keep it consistent? src/master/master.cpp <https://reviews.apache.org/r/21279/#comment76999> This case is possible given the current state of the code, when we remove a framework, how about adjusting this message to say: LOG(WARNING) << "Removing task " << task->task_id() << " of framework " << task->framework_id() << " in non-terminal state " << task->state(); - Ben Mahler On May 14, 2014, 7:25 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21279/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 7:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 12111cf7b183438f540bb0aad17e50e3f367558a > src/master/master.cpp 2f0e9027c5bea8066ac13996451d4905a422336e > src/tests/master_tests.cpp dcda0c79a6693bc3c0b69b4c9b148f9608342738 > > Diff: https://reviews.apache.org/r/21279/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified. > > > Thanks, > > Dominic Hamon > >
