> On May 14, 2014, 1:05 p.m., Ben Mahler wrote: > > Hey Dominic, what will these Gauge methods expose when: > > > > (1) A Master fails over. > > (2) All the slaves re-register w/ tasks. > > (3) The framework has not re-registered yet! > > (4) We hit the endpoint, this will say 0 tasks in each state right? > > > > We may want to loop over the slaves instead here.
Yes, they'll show 0 until frameworks reregister. How long do we normally have slaves with tasks and no frameworks? My expectation is that the framework is the canonical source of truth for the tasks and their states; if it should be the slave structures instead then we should loop over the slaves. > On May 14, 2014, 1:05 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 3882-3920 > > <https://reviews.apache.org/r/21279/diff/6/?file=581336#file581336line3882> > > > > Shouldn't these be with the other gauge definitions, rather than below > > ~Metrics? > > > > How about s/taskCount/count/ and s/++count/count++/ to keep it > > consistent? we really should default to pre-increment so that muscle memory doesn't cause us to create temporaries unnecessarily when not using base types. This was consistent with how I wrote the previous patch ;) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review43009 ----------------------------------------------------------- On May 14, 2014, 12:25 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21279/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 12:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 12111cf7b183438f540bb0aad17e50e3f367558a > src/master/master.cpp 2f0e9027c5bea8066ac13996451d4905a422336e > src/tests/master_tests.cpp dcda0c79a6693bc3c0b69b4c9b148f9608342738 > > Diff: https://reviews.apache.org/r/21279/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified. > > > Thanks, > > Dominic Hamon > >
