----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review42930 -----------------------------------------------------------
Ship it! Looks like this needs a rebase? $ ./support/apply-review.sh 21279 error: patch failed: src/master/master.cpp:3747 error: src/master/master.cpp: patch does not apply Failed to apply patch src/master/master.hpp <https://reviews.apache.org/r/21279/#comment76857> How about we move this above the message counters, since this is more important? Ditto for the constructor, initializer, and destructor. src/master/master.cpp <https://reviews.apache.org/r/21279/#comment76858> How about s/tasks/count/? - Ben Mahler On May 13, 2014, 9:31 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21279/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 9:31 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 923552e3c7f9942d6be7a0446b44e40f53c11433 > src/master/master.cpp 569995c2eaf758f5171c4e0d082d4e519a143025 > > Diff: https://reviews.apache.org/r/21279/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified. > > > Thanks, > > Dominic Hamon > >
