> On May 21, 2014, 3:33 a.m., Ben Mahler wrote: > > Higher level comment, why didn't you update removeOffer to make the > > necessary call on the allocator?
To be more clear, why not have a 'useOffer' and a 'discardOffer' for the two cases we care about? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21750/#review43578 ----------------------------------------------------------- On May 21, 2014, 3 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21750/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 3 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1400 > https://issues.apache.org/jira/browse/MESOS-1400 > > > Repository: mesos-git > > > Description > ------- > > Fixed Master::launchTasks() to inform allocator of unused resources when any > of the offers are invalid. > > > Diffs > ----- > > src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 > src/tests/master_tests.cpp 1ea1da685420aeee4cbed4765d7cfdf31fc7231f > > Diff: https://reviews.apache.org/r/21750/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
