> On May 28, 2014, 10:02 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 3700-3702 > > <https://reviews.apache.org/r/21750/diff/2/?file=595659#file595659line3700> > > > > More specifically, I think it might be more readable to have multiple > > methods here, rather than one method with boolean flags: > > > > useOffer(offerId); > > rescindOffer(offerId); > > discardOffer(offerId); > > > > Because adding more booleans here is problematic, unless you used an > > enum to denote how to remove it: USE, DISCARD, RESCIND. Maybe more guidance > > in the TODO?
agreed. amended the TODO. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21750/#review44184 ----------------------------------------------------------- On May 29, 2014, 12:17 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21750/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1400 > https://issues.apache.org/jira/browse/MESOS-1400 > > > Repository: mesos-git > > > Description > ------- > > Fixed Master::launchTasks() to inform allocator of unused resources when any > of the offers are invalid. > > > Diffs > ----- > > src/master/master.cpp efb4de1216df3fccf3706a5c615960ec00434440 > src/tests/master_tests.cpp b0ff6277120636fe9045b12443e5e2dd29a3df1b > > Diff: https://reviews.apache.org/r/21750/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
