----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21750/#review44184 -----------------------------------------------------------
Ship it! Looks good thanks! src/master/master.cpp <https://reviews.apache.org/r/21750/#comment78508> Don't think you need any of these 'stringify' calls. src/master/master.cpp <https://reviews.apache.org/r/21750/#comment78509> More specifically, I think it might be more readable to have multiple methods here, rather than one method with boolean flags: useOffer(offerId); rescindOffer(offerId); discardOffer(offerId); Because adding more booleans here is problematic, unless you used an enum to denote how to remove it: USE, DISCARD, RESCIND. Maybe more guidance in the TODO? - Ben Mahler On May 28, 2014, 2:03 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21750/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 2:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1400 > https://issues.apache.org/jira/browse/MESOS-1400 > > > Repository: mesos-git > > > Description > ------- > > Fixed Master::launchTasks() to inform allocator of unused resources when any > of the offers are invalid. > > > Diffs > ----- > > src/master/master.cpp 21472e94658be6e31f13eacc5412144d62b12096 > src/tests/master_tests.cpp f607d89b17b9347cd4fb3a715d268e59559de1f6 > > Diff: https://reviews.apache.org/r/21750/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
