-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22222/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.


Bugs: MESOS-1391
    https://issues.apache.org/jira/browse/MESOS-1391


Repository: mesos-git


Description
-------

After Ben's comments, regroup of all types of authentication in one common 
definition, this is a draft for this Issue, here are some questions:

- Do I replace credentials flag completely or if this slight duplication will 
suffice for now ?
- If I don't replace it, for now as it is in this patch, the flag is useless, I 
should give it to the sasl/authenticator but I would really appreciate some 
comments for that part.


Diffs
-----

  src/authentications/authentications.hpp PRE-CREATION 
  src/master/flags.hpp 4863359 
  src/master/master.cpp 766a0e3 
  src/messages/messages.proto 6f6e570 

Diff: https://reviews.apache.org/r/22222/diff/


Testing
-------


Thanks,

Isabel Jimenez

Reply via email to