-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22222/#review44821
-----------------------------------------------------------
Bad patch!
Reviews applied: [22222]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
zip_safe flag not set; analyzing archive contents...
../../src/master/master.cpp:56:47: fatal error:
authentications/authentications.hpp: No such file or directory
compilation terminated.
make[3]: *** [master/libmesos_no_3rdparty_la-master.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On June 3, 2014, 11:15 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22222/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
>
>
> Bugs: MESOS-1391
> https://issues.apache.org/jira/browse/MESOS-1391
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> After Ben's comments, regroup of all types of authentication in one common
> definition, this is a draft for this Issue, here are some questions:
>
> - Do I replace credentials flag completely or if this slight duplication will
> suffice for now ?
> - If I don't replace it, for now as it is in this patch, the flag is useless,
> I should give it to the sasl/authenticator but I would really appreciate some
> comments for that part.
>
>
> Diffs
> -----
>
> src/authentications/authentications.hpp PRE-CREATION
> src/master/flags.hpp 4863359
> src/master/master.cpp 766a0e3
> src/messages/messages.proto 6f6e570
>
> Diff: https://reviews.apache.org/r/22222/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
