> On April 9, 2014, 1:22 p.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/cgroups/mem.cpp, lines 91-92 > > <https://reviews.apache.org/r/20137/diff/1/?file=553431#file553431line91> > > > > It's a bit unfortunate that the code is not that clear without the > > comments. We're passing 'true' into something called 'oom_control' which > > doesn't really tell us that we're enabling the oom killer. Seems like this > > is a place where the direct mapping from control names to function names is > > a bit unfortunate. > > > > I guess this is ok for now.
I changed the method to oom_control_enabled() with an Option<bool> to change state. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review39927 ----------------------------------------------------------- On June 8, 2014, 8:54 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20137/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 8:54 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1178 > https://issues.apache.org/jira/browse/MESOS-1178 > > > Repository: mesos-git > > > Description > ------- > > Added cgroups::memory::oom_control and cgroups::memory::listen. > > cgroups::memory::oom_control will not write to the control file unless it > needs to change the state. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e > src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1 > src/slave/containerizer/isolators/cgroups/mem.hpp > 362ebcfa2e16701b225deea0fbeb92e4a56d51aa > src/slave/containerizer/isolators/cgroups/mem.cpp > 60013d4e840f6b1f131b796b95916d1978b37c70 > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > > Diff: https://reviews.apache.org/r/20137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
