----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review45540 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/20137/#comment80387> Can we split this into two methods? An Option<bool> seems a bit weird. oom_control_enabled() and oom_control_enable() - Vinod Kone On June 9, 2014, 3:54 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20137/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 3:54 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1178 > https://issues.apache.org/jira/browse/MESOS-1178 > > > Repository: mesos-git > > > Description > ------- > > Added cgroups::memory::oom_control and cgroups::memory::listen. > > cgroups::memory::oom_control will not write to the control file unless it > needs to change the state. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e > src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1 > src/slave/containerizer/isolators/cgroups/mem.hpp > 362ebcfa2e16701b225deea0fbeb92e4a56d51aa > src/slave/containerizer/isolators/cgroups/mem.cpp > 60013d4e840f6b1f131b796b95916d1978b37c70 > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > > Diff: https://reviews.apache.org/r/20137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
