----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20137/#review46025 -----------------------------------------------------------
Ship it! There's a bug that can crash the program, but otherwise looks good. Please go ahead and commit after addressing comments. src/linux/cgroups.cpp <https://reviews.apache.org/r/20137/#comment81189> You can't call .error() if 'exists' is false! src/linux/cgroups.cpp <https://reviews.apache.org/r/20137/#comment81190> How about: return pairs["oom_kill_disable"].front() == "0"; src/linux/cgroups.cpp <https://reviews.apache.org/r/20137/#comment81191> Should this have an error prefix string like you did inside 'enabled' above? src/linux/cgroups.cpp <https://reviews.apache.org/r/20137/#comment81192> Ditto. - Ben Mahler On June 17, 2014, 9:27 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20137/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 9:27 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1178 > https://issues.apache.org/jira/browse/MESOS-1178 > > > Repository: mesos-git > > > Description > ------- > > Added cgroups::memory::oom_control and cgroups::memory::listen. > > cgroups::memory::oom_control will not write to the control file unless it > needs to change the state. > > > Diffs > ----- > > src/linux/cgroups.hpp 75c5602baa5a5bbf3bba1c6f9df61b0a2027e029 > src/linux/cgroups.cpp a4274a85939a2e84e03f67c6003182cbb0ab9b67 > src/slave/containerizer/isolators/cgroups/mem.hpp > 33b0ca8e412c0da294f7942019d5ffca15cc0130 > src/slave/containerizer/isolators/cgroups/mem.cpp > 3b731f90e452d3dd6496988273e3b1ec69c9b4f7 > src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc > > Diff: https://reviews.apache.org/r/20137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
