----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22425/#review45281 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/22425/#comment80042> Another option is to just have the users set both "permits" and "duration". Then you dont need to worry about precision. Not sure how user friendly is that though. Have you looked around at examples on the interwebs? src/master/flags.hpp <https://reviews.apache.org/r/22425/#comment80036> s/aurora/foo/ src/master/flags.hpp <https://reviews.apache.org/r/22425/#comment80037> s/jenkins/bar/ src/master/master.cpp <https://reviews.apache.org/r/22425/#comment80039> Change it to "Enabled rate limiting". Authorization log line is changed similarly in my current chain of review.s src/master/master.cpp <https://reviews.apache.org/r/22425/#comment80040> say "(see --rate_limits flag)" - Vinod Kone On June 10, 2014, 6:15 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22425/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:15 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1443 > https://issues.apache.org/jira/browse/MESOS-1443 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 62f69d26ba0132156081eb7cfd0f16dd1b22913d > src/master/flags.hpp 486335970ef05b345c5584ac012dde63437ef149 > src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f > src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 > > Diff: https://reviews.apache.org/r/22425/diff/ > > > Testing > ------- > > make check (tested along with https://reviews.apache.org/r/22427) > > > Thanks, > > Jiang Yan Xu > >
