> On June 10, 2014, 8:37 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 669 > > <https://reviews.apache.org/r/22425/diff/1/?file=606515#file606515line669> > > > > Another option is to just have the users set both "permits" and > > "duration". Then you dont need to worry about precision. Not sure how user > > friendly is that though. Have you looked around at examples on the > > interwebs? > > Jiang Yan Xu wrote: > Not configuration examples for end products but Guava's RateLimiter takes > a "double permitsPerSecond" in its creator method. Perhaps we can use that > for our RateLimiter as well? It's internally converted to a 'double rate'. We > can just store the 'rate' and add an overload constructor for RateLimiter > that takes a "double permitsPerSecond". What do you think?
sgtm. @benh: any objections? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22425/#review45281 ----------------------------------------------------------- On June 10, 2014, 6:15 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22425/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:15 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1443 > https://issues.apache.org/jira/browse/MESOS-1443 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 62f69d26ba0132156081eb7cfd0f16dd1b22913d > src/master/flags.hpp 486335970ef05b345c5584ac012dde63437ef149 > src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f > src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 > > Diff: https://reviews.apache.org/r/22425/diff/ > > > Testing > ------- > > make check (tested along with https://reviews.apache.org/r/22427) > > > Thanks, > > Jiang Yan Xu > >
