----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22425/#review45681 -----------------------------------------------------------
Ship it! Vinod and I went over this, just a few comments below about naming and having the ability to specify a default if desired. include/mesos/mesos.proto <https://reviews.apache.org/r/22425/#comment80621> How about calling this just 'qps', it's not clear what meaning 'maximum' may have in the future as we consider bursting capabilities? include/mesos/mesos.proto <https://reviews.apache.org/r/22425/#comment80622> It would be nice to allow operators to explicitly specify default QPS for principals that are not specified in the limits. We could do this pretty easily by adding an optional 'default_qps' field here: // QPS for unspecified principals, if left unset, then no rate limit will be enforced. optional default_qps = 2; src/master/flags.hpp <https://reviews.apache.org/r/22425/#comment80623> Make sure to update this as you change the protobuf. - Ben Mahler On June 13, 2014, 11 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22425/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 11 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1443 > https://issues.apache.org/jira/browse/MESOS-1443 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 8c6933db495ef0bb3c14301d8077d31ecb123f59 > src/master/flags.hpp 780e219e81e3df57da197784f67deab2b0de4382 > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > > Diff: https://reviews.apache.org/r/22425/diff/ > > > Testing > ------- > > make check (tested along with https://reviews.apache.org/r/22427) > > > Thanks, > > Jiang Yan Xu > >
