----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22740/#review46243 -----------------------------------------------------------
Only partial review. But after looking at some tests, this parameterizing test behavior inside the tests seems more complicated than its worth. I think its better to just convert all these tests to rate limiting tests. We have lot of other tests in our code base that test the code without rate limiting. You could still ensure that the counters are correct when you are using rate limiting. The correctness of the counters code doesn't depend on whether you are rate limiting or not, so it should be fine. Thoughts? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81555> Instead of doing this..why not just overload CreateMasterFlags() like we did in slave recovery tests? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81561> Can you do it after you start the master? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81560> you can kill this. this is done by the test teardown by default. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81562> ditto. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81563> s/and and/and/ - Vinod Kone On June 19, 2014, 7:03 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22740/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 7:03 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1445 > https://issues.apache.org/jira/browse/MESOS-1445 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 > > Diff: https://reviews.apache.org/r/22740/diff/ > > > Testing > ------- > > make check all test and *RateLimitingTest* for high iterations. > > > Thanks, > > Jiang Yan Xu > >
