----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22740/#review46349 -----------------------------------------------------------
Ship it! src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81680> Kill this. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81682> s/+/ +/ src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81683> update the comment. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81684> s/could/should/ src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81685> s/if we are throttling// Looks some of these comments were not updated after removal of templatization. Can you make a pass and make sure they are updated? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81687> s/it's/ as it's/ src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22740/#comment81688> Why do you need to pass CreateMasterFlags() here? - Vinod Kone On June 20, 2014, 11:37 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22740/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 11:37 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1445 > https://issues.apache.org/jira/browse/MESOS-1445 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 > > Diff: https://reviews.apache.org/r/22740/diff/ > > > Testing > ------- > > make check all test and *RateLimitingTest* for high iterations. > > > Thanks, > > Jiang Yan Xu > >
