> On June 20, 2014, 5:19 p.m., Vinod Kone wrote: > > src/tests/rate_limiting_tests.cpp, line 521 > > <https://reviews.apache.org/r/22740/diff/3/?file=614447#file614447line521> > > > > s/if we are throttling// > > > > Looks some of these comments were not updated after removal of > > templatization. Can you make a pass and make sure they are updated?
Thanks for catching these :) I did a another pass and should be OK now. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22740/#review46349 ----------------------------------------------------------- On June 22, 2014, 8:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22740/ > ----------------------------------------------------------- > > (Updated June 22, 2014, 8:49 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1445 > https://issues.apache.org/jira/browse/MESOS-1445 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 > > Diff: https://reviews.apache.org/r/22740/diff/ > > > Testing > ------- > > make check all test and *RateLimitingTest* for high iterations. > > > Thanks, > > Jiang Yan Xu > >
