> On June 17, 2014, 12:26 a.m., Ian Downes wrote: > >
changed to isolator tests. i've dropped issues that no longer apply. > On June 17, 2014, 12:26 a.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, line 111 > > <https://reviews.apache.org/r/22471/diff/2/?file=608378#file608378line111> > > > > Also seen this more than once - put an implementation into stout? This is only used here once. Mainly I am not sure how good this idea is to rely on /etc/resolv.conf to get some external hosts. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22471/#review45851 ----------------------------------------------------------- On June 24, 2014, 7:33 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22471/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 7:33 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > These tests test different different protocols (TCP, UDP, ICMP, ARP, DNS) in > different connection scenarios (C2C, H2C). > > > Diffs > ----- > > src/tests/isolator_tests.cpp 6fef4e0 > > Diff: https://reviews.apache.org/r/22471/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Chi Zhang > >
