> On June 24, 2014, 9:43 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 780 > > <https://reviews.apache.org/r/22471/diff/4/?file=616170#file616170line780> > > > > Should we parse them into net::IP?
I thought about it, but we only just need the string representation. > On June 24, 2014, 9:43 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 810 > > <https://reviews.apache.org/r/22471/diff/4/?file=616170#file616170line810> > > > > Why option here? net::IP doesn't have a default constructor. > On June 24, 2014, 9:43 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 910 > > <https://reviews.apache.org/r/22471/diff/4/?file=616170#file616170line910> > > > > Why this comment? not really a reason, other than it is used in all the test cases in this file. > On June 24, 2014, 9:43 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, lines 903-904 > > <https://reviews.apache.org/r/22471/diff/4/?file=616170#file616170line903> > > > > You don't need these two 'None()' here. won't compile. > On June 24, 2014, 9:43 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 922 > > <https://reviews.apache.org/r/22471/diff/4/?file=616170#file616170line922> > > > > Probably add a sleep here (instead of busy waiting)? like > > os::sleep(Milliseconds(10)); I think it would help, but i don't think performance is a big deal here. Also for being consistent with other tests. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22471/#review46562 ----------------------------------------------------------- On June 25, 2014, 2:10 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22471/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 2:10 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > These tests test different different protocols (TCP, UDP, ICMP, ARP, DNS) in > different connection scenarios (C2C, H2C). > > > Diffs > ----- > > src/tests/isolator_tests.cpp 0bbec09 > > Diff: https://reviews.apache.org/r/22471/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Chi Zhang > >
