> On June 25, 2014, 4:32 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 743 > > <https://reviews.apache.org/r/22471/diff/5/?file=616523#file616523line743> > > > > Can you remind me why this needs to be MesosTest?
> On June 25, 2014, 4:32 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, lines 859-861 > > <https://reviews.apache.org/r/22471/diff/5/?file=616523#file616523line859> > > > > I would suggest not making 'pipes' and 'command1' 'command2' a class > > field. Especially for pipes, make sure all pipes you created get closed. kept pipes as a class member so that it doesn't have to passed to launchHelper every time, but I moved the ::pipe call down to individual tests. command1 and command2 are local var now. > On June 25, 2014, 4:32 p.m., Jie Yu wrote: > > src/tests/isolator_tests.cpp, line 841 > > <https://reviews.apache.org/r/22471/diff/5/?file=616523#file616523line841> > > > > We've changed to MesosContainerizerLaunch::NAME will wait until I merge with master. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22471/#review46636 ----------------------------------------------------------- On June 26, 2014, 6:03 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22471/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 6:03 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > These tests test different different protocols (TCP, UDP, ICMP, ARP, DNS) in > different connection scenarios (C2C, H2C). > > > Diffs > ----- > > src/tests/isolator_tests.cpp 6fef4e0 > > Diff: https://reviews.apache.org/r/22471/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Chi Zhang > >
