----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22471/#review46764 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82332> Move this above #include "linux/routing/link/link.hpp" src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82338> You should call "cleanup" here? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82333> Use tests::flags.launcher_dir to avoid confusion src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82336> It should be: char dummy; ASSERT_LT(0, ::write(pipes[1], &dummy, sizeof(dummy))); Here and everywhere else src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82337> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82339> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82340> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82341> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82342> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82343> Ditto. - Jie Yu On June 26, 2014, 6:03 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22471/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 6:03 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > These tests test different different protocols (TCP, UDP, ICMP, ARP, DNS) in > different connection scenarios (C2C, H2C). > > > Diffs > ----- > > src/tests/isolator_tests.cpp 6fef4e0 > > Diff: https://reviews.apache.org/r/22471/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Chi Zhang > >
