> On June 30, 2014, 4:13 p.m., Dominic Hamon wrote: > > src/master/master.cpp, line 4354 > > <https://reviews.apache.org/r/23147/diff/1/?file=620068#file620068line4354> > > > > have you considered renaming the metrics? > > Alexandra Sava wrote: > How do you suggest to rename them? slaves_registered is not ok in my > opinion because the opposite is slaves_unregistered. I can't rename > slaves_inactive into slaves_unregistered because this method does not return > the number of unregistered slaves. > I think slaves_connected/slaves_disconnected is more suitable for this > context, but there currently is a debate whether to rename > 'slave->disconnected' into 'slave->active' or not. > > Dominic Hamon wrote: > my preference is that the metrics reflect the underlying variable, so > when the debate is settled it should be clear.
So this methods should count the number of activated slaves (which are slaves for which no resource offers are sent, according to MESOS-1476). Currently slaves are marked as deactivated when they are disconnected (please have a look @ Master::disconnect method). Since slaves can not be deactivated in any other way (just for now), it is correct what this method does (counts the number of disconnected slaves). I'm currently working on MESOS-1476 and when it will be committed, I will change this method to also consider the slaves deactivated by HTTP POSTS. I will add a TODO there. I will create metrics for registered and removed slaves in another review. - Alexandra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/#review46985 ----------------------------------------------------------- On July 11, 2014, 1:28 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23147/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 1:28 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1188 > https://issues.apache.org/jira/browse/MESOS-1188 > > > Repository: mesos-git > > > Description > ------- > > The existing terminology is confusing both for "slaves.deactivated" and > "frameworks.activated". Currently a deactivated slave actually represents a > removed/shutdown slave and "frameworks.activated" map holds both activated > and deactivated frameworks. > In order to make things look clear, rename the following: > * master.slaves.deactivated -> master.slaves.removed > * master.slaves.activated -> master.slaves.registered > * master.frameworks.activated -> master.frameworks.registered > * allocator.slaveDisconnect -> allocator.slaveDeactivate > * allocator.slaveReconnected -> allocator.slaveReactivated > > > Diffs > ----- > > src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 > src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad > src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 > src/master/hierarchical_allocator_process.hpp > 1765e7035bdda4c28e79d74c92e77dcc99759001 > src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 > src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 > src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 > src/tests/fault_tolerance_tests.cpp > ac65050bec5720b982f53d4dd6797cc3dee285dc > src/tests/master_authorization_tests.cpp > 0fdf464cc4a562afec276ec604205af3b56636de > src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb > src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e > > Diff: https://reviews.apache.org/r/23147/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
