> On July 8, 2014, 1:53 a.m., Adam B wrote: > > src/master/http.cpp, lines 356-358 > > <https://reviews.apache.org/r/23147/diff/2/?file=624768#file624768line356> > > > > Add a comment here for when we can remove them (0.21 if this goes into > > 0.20?) > > Alexandra Sava wrote: > Ok so since I'm currently working on MESOS-1476 and I plan to name > 'active slaves'/'deactive slaves' the slaves for which resource offers are / > are not sent, we will need a statistic for that as well. Since we already > have it but it's not counting the right thing, I will change it to count the > right thing: the number of active slaves (slaves for which resource offers > are sent). Currently, the only way slaves can get deactivated is when they > are disconnected (please have a look @ Master::disconnect method). So, in > order to count the deactivated slaves it's enough to count the disconnected > slaves (there already is a method that counts this: > Master::_slaves_inactive()). > > Once MESOS-1476 gets commited, I will change _slaves_active method (which > currently counts the disconnected slaves - which are also deactivated slaves) > to also count the slaves that have been deactivated via HTTP POSTs. I will > add a TODO for that. > > Also, we need metrics and stats for "registered_slaves"/"removed_slaves". > I will create a separate review for that. I will add just a TODO now. >
Sounds great! - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/#review47434 ----------------------------------------------------------- On July 11, 2014, 6:28 a.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23147/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 6:28 a.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1188 > https://issues.apache.org/jira/browse/MESOS-1188 > > > Repository: mesos-git > > > Description > ------- > > The existing terminology is confusing both for "slaves.deactivated" and > "frameworks.activated". Currently a deactivated slave actually represents a > removed/shutdown slave and "frameworks.activated" map holds both activated > and deactivated frameworks. > In order to make things look clear, rename the following: > * master.slaves.deactivated -> master.slaves.removed > * master.slaves.activated -> master.slaves.registered > * master.frameworks.activated -> master.frameworks.registered > * allocator.slaveDisconnect -> allocator.slaveDeactivate > * allocator.slaveReconnected -> allocator.slaveReactivated > > > Diffs > ----- > > src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 > src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad > src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 > src/master/hierarchical_allocator_process.hpp > 1765e7035bdda4c28e79d74c92e77dcc99759001 > src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 > src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 > src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 > src/tests/fault_tolerance_tests.cpp > ac65050bec5720b982f53d4dd6797cc3dee285dc > src/tests/master_authorization_tests.cpp > 0fdf464cc4a562afec276ec604205af3b56636de > src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb > src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e > > Diff: https://reviews.apache.org/r/23147/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
