----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/#review47691 -----------------------------------------------------------
Ship it! Looks great! Please add your id to the TODOs and rebase against the latest master (if you haven't already), and I would be happy to commit this for you. src/master/http.cpp <https://reviews.apache.org/r/23147/#comment83838> Please add your userid to the TODO: // TODO(alexandra.sava) Add... (Same for the other TODOs in here.) src/master/http.cpp <https://reviews.apache.org/r/23147/#comment83839> While I agree that these are the correct new values for the new interpretations of the activated/deactivated terms, I hope nobody was depending on the old meanings of these stats. I could imagine keeping activated|deactivated_slaves to the old meaning (registered/removed) and adding new active|inactive_slaves stats, but that would be too confusing to a first-time stats viewer. Better to change them and document. That said, I don't know if it would be better to document it in docs/upgrades.md (mostly about the upgrade process) or just put a note in the CHANGELOG or release notes blog. I'll ask around, but that shouldn't stop us from committing this. src/master/http.cpp <https://reviews.apache.org/r/23147/#comment83840> Ditto. src/master/master.cpp <https://reviews.apache.org/r/23147/#comment83841> // TODO(alexandra.sava): Count... src/master/master.cpp <https://reviews.apache.org/r/23147/#comment83842> // TODO(alexandra.sava): Add... - Adam B On July 11, 2014, 6:28 a.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23147/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 6:28 a.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1188 > https://issues.apache.org/jira/browse/MESOS-1188 > > > Repository: mesos-git > > > Description > ------- > > The existing terminology is confusing both for "slaves.deactivated" and > "frameworks.activated". Currently a deactivated slave actually represents a > removed/shutdown slave and "frameworks.activated" map holds both activated > and deactivated frameworks. > In order to make things look clear, rename the following: > * master.slaves.deactivated -> master.slaves.removed > * master.slaves.activated -> master.slaves.registered > * master.frameworks.activated -> master.frameworks.registered > * allocator.slaveDisconnect -> allocator.slaveDeactivate > * allocator.slaveReconnected -> allocator.slaveReactivated > > > Diffs > ----- > > src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 > src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad > src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 > src/master/hierarchical_allocator_process.hpp > 1765e7035bdda4c28e79d74c92e77dcc99759001 > src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 > src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 > src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 > src/tests/fault_tolerance_tests.cpp > ac65050bec5720b982f53d4dd6797cc3dee285dc > src/tests/master_authorization_tests.cpp > 0fdf464cc4a562afec276ec604205af3b56636de > src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb > src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e > > Diff: https://reviews.apache.org/r/23147/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
