-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23542/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-1525
https://issues.apache.org/jira/browse/MESOS-1525
Repository: mesos-git
Description
-------
I would recommend applying this patch to review the reconcileTasks() logic
instead of using the diff viewer.
Reconciliation requests currently specify a list of TaskStatuses. SlaveID is
optional inside TaskStatus but reconciliation requests are dropped when the
SlaveID is not specified. We can answer reconciliation requests for a task so
long as there are no transient slaves, this is what we should do when the slave
id is not specified.
Also, I realized that we should answer when a non-strict registry is in use,
see the comment.
Diffs
-----
src/common/protobuf_utils.hpp 12ff00a2e1262d785dbd6ec4d54e50d88d611e20
src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39
src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4
src/tests/reconciliation_tests.cpp 6edbf7563375a69e3148e74a8cd99ddd13fc445b
Diff: https://reviews.apache.org/r/23542/diff/
Testing
-------
Removed a test that is now invalid and added a test for pending tasks.
Thanks,
Ben Mahler
