----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23542/#review48149 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/23542/#comment84445> pull "||" up to the end of the previous lines? src/master/master.cpp <https://reviews.apache.org/r/23542/#comment84446> s/will/can/ src/master/master.cpp <https://reviews.apache.org/r/23542/#comment84447> pull this below the first if loop. src/master/master.cpp <https://reviews.apache.org/r/23542/#comment84448> I remember we talked about this. But sending a TASK_STAGING here might be better here for frameworks than ignoring? we could consider the act of validation/authorization and sending it to the slave all part of "staging" the task. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/23542/#comment84456> pull this below the offers expectation. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/23542/#comment84460> s/,/;/ src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/23542/#comment84461> if you havent already, please make sure it run this test a few hundred times to avoid flakiness. - Vinod Kone On July 16, 2014, 3:16 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23542/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 3:16 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1525 > https://issues.apache.org/jira/browse/MESOS-1525 > > > Repository: mesos-git > > > Description > ------- > > I would recommend applying this patch to review the reconcileTasks() logic > instead of using the diff viewer. > > Reconciliation requests currently specify a list of TaskStatuses. SlaveID is > optional inside TaskStatus but reconciliation requests are dropped when the > SlaveID is not specified. We can answer reconciliation requests for a task so > long as there are no transient slaves, this is what we should do when the > slave id is not specified. > > Also, I realized that we should answer when a non-strict registry is in use, > see the comment. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 12ff00a2e1262d785dbd6ec4d54e50d88d611e20 > src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39 > src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4 > src/tests/reconciliation_tests.cpp 6edbf7563375a69e3148e74a8cd99ddd13fc445b > > Diff: https://reviews.apache.org/r/23542/diff/ > > > Testing > ------- > > Removed a test that is now invalid and added a test for pending tasks. > > > Thanks, > > Ben Mahler > >
