-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23542/
-----------------------------------------------------------
(Updated July 21, 2014, 7:57 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased and updated per comments.
Bugs: MESOS-1525
https://issues.apache.org/jira/browse/MESOS-1525
Repository: mesos-git
Description
-------
I would recommend applying this patch to review the reconcileTasks() logic
instead of using the diff viewer.
Reconciliation requests currently specify a list of TaskStatuses. SlaveID is
optional inside TaskStatus but reconciliation requests are dropped when the
SlaveID is not specified. We can answer reconciliation requests for a task so
long as there are no transient slaves, this is what we should do when the slave
id is not specified.
Also, I realized that we should answer when a non-strict registry is in use,
see the comment.
Diffs (updated)
-----
src/master/master.hpp 7e7a75bd7e0fafc084ad2663c894e76e5fb35edd
src/master/master.cpp dc60c47b9c08b1e83fd72b6b86393fdc11314ea1
src/tests/reconciliation_tests.cpp 6edbf7563375a69e3148e74a8cd99ddd13fc445b
Diff: https://reviews.apache.org/r/23542/diff/
Testing
-------
Removed a test that is now invalid and added a test for pending tasks.
Thanks,
Ben Mahler
