----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23701/#review48263 -----------------------------------------------------------
Ship it! src/linux/routing/filter/handle.hpp <https://reviews.apache.org/r/23701/#comment84641> What other types of handles can there by? From the signature of this method, it looks like only u32 handle is possible? src/linux/routing/filter/ip.hpp <https://reviews.apache.org/r/23701/#comment84670> s/Same to/Same as/ src/tests/routing_tests.cpp <https://reviews.apache.org/r/23701/#comment84675> what happens if this handle already exists? - Vinod Kone On July 18, 2014, 11:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23701/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 11:57 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1617 > https://issues.apache.org/jira/browse/MESOS-1617 > > > Repository: mesos-git > > > Description > ------- > > See ticket. I introduced a Handle class in routing::filter. To workaround, I > mimic the kernel logic to generate handles (except that I fixed the bug) and > set the handle explicitly. > > > Diffs > ----- > > src/linux/routing/filter/arp.cpp c18aebb > src/linux/routing/filter/filter.hpp 40e21db > src/linux/routing/filter/handle.hpp PRE-CREATION > src/linux/routing/filter/icmp.cpp 8e6f013 > src/linux/routing/filter/internal.hpp 6836d1f > src/linux/routing/filter/ip.hpp 11e417d > src/linux/routing/filter/ip.cpp 43f1f7f > src/tests/routing_tests.cpp dcc4982 > > Diff: https://reviews.apache.org/r/23701/diff/ > > > Testing > ------- > > sudo make check > sudo bin/mesos-tests.sh --gtest_filter=*Routing* --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
