> On July 21, 2014, 7:25 p.m., Vinod Kone wrote: > > src/tests/routing_tests.cpp, line 1053 > > <https://reviews.apache.org/r/23701/diff/2/?file=635993#file635993line1053> > > > > what happens if this handle already exists?
That's not possible. I created TEST_VETH_LINK, and a handle is always associated with a link. > On July 21, 2014, 7:25 p.m., Vinod Kone wrote: > > src/linux/routing/filter/handle.hpp, line 36 > > <https://reviews.apache.org/r/23701/diff/2/?file=635988#file635988line36> > > > > What other types of handles can there by? From the signature of this > > method, it looks like only u32 handle is possible? For example, for basic handles (for basic filters), their handles are different from u32 handles (they don't have htid, hash and mode, just a plain 32 bit number). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23701/#review48263 ----------------------------------------------------------- On July 18, 2014, 11:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23701/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 11:57 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1617 > https://issues.apache.org/jira/browse/MESOS-1617 > > > Repository: mesos-git > > > Description > ------- > > See ticket. I introduced a Handle class in routing::filter. To workaround, I > mimic the kernel logic to generate handles (except that I fixed the bug) and > set the handle explicitly. > > > Diffs > ----- > > src/linux/routing/filter/arp.cpp c18aebb > src/linux/routing/filter/filter.hpp 40e21db > src/linux/routing/filter/handle.hpp PRE-CREATION > src/linux/routing/filter/icmp.cpp 8e6f013 > src/linux/routing/filter/internal.hpp 6836d1f > src/linux/routing/filter/ip.hpp 11e417d > src/linux/routing/filter/ip.cpp 43f1f7f > src/tests/routing_tests.cpp dcc4982 > > Diff: https://reviews.apache.org/r/23701/diff/ > > > Testing > ------- > > sudo make check > sudo bin/mesos-tests.sh --gtest_filter=*Routing* --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
