> On July 21, 2014, 7:04 p.m., Chi Zhang wrote: > > src/linux/routing/filter/internal.hpp, line 340 > > <https://reviews.apache.org/r/23701/diff/2/?file=635990#file635990line340> > > > > why is this? Is this because prio decides htid? what decides bucket > > number?
We use the default divisor (which is 1) created by the kernel. So there will be only one bucket (0x0). Added a comment. > On July 21, 2014, 7:04 p.m., Chi Zhang wrote: > > src/tests/routing_tests.cpp, line 1057 > > <https://reviews.apache.org/r/23701/diff/2/?file=635993#file635993line1057> > > > > is this tested in some way? Changed the test. If two filters have the same handle, removing the second one should fail. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23701/#review48267 ----------------------------------------------------------- On July 18, 2014, 11:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23701/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 11:57 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1617 > https://issues.apache.org/jira/browse/MESOS-1617 > > > Repository: mesos-git > > > Description > ------- > > See ticket. I introduced a Handle class in routing::filter. To workaround, I > mimic the kernel logic to generate handles (except that I fixed the bug) and > set the handle explicitly. > > > Diffs > ----- > > src/linux/routing/filter/arp.cpp c18aebb > src/linux/routing/filter/filter.hpp 40e21db > src/linux/routing/filter/handle.hpp PRE-CREATION > src/linux/routing/filter/icmp.cpp 8e6f013 > src/linux/routing/filter/internal.hpp 6836d1f > src/linux/routing/filter/ip.hpp 11e417d > src/linux/routing/filter/ip.cpp 43f1f7f > src/tests/routing_tests.cpp dcc4982 > > Diff: https://reviews.apache.org/r/23701/diff/ > > > Testing > ------- > > sudo make check > sudo bin/mesos-tests.sh --gtest_filter=*Routing* --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
