----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23911/#review48705 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp <https://reviews.apache.org/r/23911/#comment85467> Aren't there potentially multiple keys for a particular value? i.e. Option<hashset<K> > getKeys(const V& value) const; Or should the calling code just iterate through the map for now to find the first key? - Ben Mahler On July 25, 2014, 12:40 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23911/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 12:40 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-947 > https://issues.apache.org/jira/browse/MESOS-947 > > > Repository: mesos-git > > > Description > ------- > > Small extension of stout that is useful for fixing MESOS-947, but also in > general. adding a getKey() method to multihashmap, which finds a key given a > value in the map. > > A dependent Mesos patch fixing MESOS-947 will follow promptly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp ecda6a9 > > Diff: https://reviews.apache.org/r/23911/diff/ > > > Testing > ------- > > The method behaves as expected in the unit test for MESOS-947. I did not > create stout unit tests for it. (There is no precedence for testing > multihashmap and this particular piece of code is very straightforward.) > > > Thanks, > > Bernd Mathiske > >
