> On July 24, 2014, 5:51 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, line 42 > > <https://reviews.apache.org/r/23911/diff/1/?file=641620#file641620line42> > > > > Aren't there potentially multiple keys for a particular value? > > > > i.e. Option<hashset<K> > getKeys(const V& value) const; > > > > Or should the calling code just iterate through the map for now to find > > the first key? > > Ben Mahler wrote: > Sorry, the Option was unnecessary. :) > > Bernd Mathiske wrote: > I could add the method that returns all keys for a given value, but I do > not have a use case for it. > > Ben Mahler wrote: > My concern is that it seems to be tailored to your particular use-case, > where you happen to have unique values per key. But this is not an inherent > property of multimap. > > For your use-case getKeys() is equivalent: > > getKey getKeys > None <-> Empty set > Some K <-> Non-empty set (use *iterator.begin() to obtain the only key) > > Or you could just iterate the map since there only appears to be one use > case so far?
OK, I will change it to getKeys(), which returns all keys. This will make my code more complex and slower, but it does not matter here. It only gets executed when a task has been lost or killed between runTask() and _runTask(). - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23911/#review48705 ----------------------------------------------------------- On July 24, 2014, 5:40 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23911/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 5:40 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-947 > https://issues.apache.org/jira/browse/MESOS-947 > > > Repository: mesos-git > > > Description > ------- > > Small extension of stout that is useful for fixing MESOS-947, but also in > general. adding a getKey() method to multihashmap, which finds a key given a > value in the map. > > A dependent Mesos patch fixing MESOS-947 will follow promptly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp ecda6a9 > > Diff: https://reviews.apache.org/r/23911/diff/ > > > Testing > ------- > > The method behaves as expected in the unit test for MESOS-947. I did not > create stout unit tests for it. (There is no precedence for testing > multihashmap and this particular piece of code is very straightforward.) > > > Thanks, > > Bernd Mathiske > >
