----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20499/#review48929 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20499/#comment85720> Is it clearer without the negation? if (filelist.isSome()) { Ditto in the cases below. 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85729> Should we use ErrnoError with the errno preserved from the malloc failure? i.e. ENOMEM 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85725> No period here. 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85727> It looks like readdir_r returns an error number that can be assigned to errno. We could use this to send back a more informative error message, right? 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85726> No period here. 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp <https://reviews.apache.org/r/20499/#comment85721> It looks like we should return return an informative error if we can't list the contents of /proc? In the current form, it will just go through the generic error case at the bottom. 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp <https://reviews.apache.org/r/20499/#comment85722> Ditto, looks like we can clarify this particular error case over what we say in the bottom. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/20499/#comment85730> Clearer as isSome()? - Ben Mahler On July 28, 2014, 10:36 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20499/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 10:36 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1237 > https://issues.apache.org/jira/browse/MESOS-1237 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 08251724fbe45431db2c3637c6beec81f5744c4c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp > e916f027e1c9918ec4f2d41e03926c10a1080bca > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > c5509632988401ee96ed2471c7278c8e164800d7 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 7fa7346346a33a05fbcd30a11053948eedba4764 > > Diff: https://reviews.apache.org/r/20499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
