> On July 28, 2014, 11:26 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp, lines 70-72 > > <https://reviews.apache.org/r/20499/diff/3/?file=643960#file643960line70> > > > > It looks like readdir_r returns an error number that can be assigned to > > errno. We could use this to send back a more informative error message, > > right? > > Dominic Hamon wrote: > not exactly. it sets a single possible error: > http://linux.die.net/man/3/readdir_r > >
POSIX has a bit more here as well: http://pubs.opengroup.org/onlinepubs/9699919799/functions/readdir.html Even if there is a single error wouldn't it be better to tell them that the file descriptor is invalid, rather than a generic message? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20499/#review48929 ----------------------------------------------------------- On July 29, 2014, 4:12 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20499/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 4:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1237 > https://issues.apache.org/jira/browse/MESOS-1237 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 08251724fbe45431db2c3637c6beec81f5744c4c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp > e916f027e1c9918ec4f2d41e03926c10a1080bca > 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp > cf2215a90d6e2673085293b8eaf5a44418da3bf0 > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > c5509632988401ee96ed2471c7278c8e164800d7 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 7fa7346346a33a05fbcd30a11053948eedba4764 > > Diff: https://reviews.apache.org/r/20499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
