----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20499/#review48959 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85797> Doesn't closedir() potentially overwrite the errno from malloc()? 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp <https://reviews.apache.org/r/20499/#comment85798> We can show the readdir_r error here by setting it to errno, no? 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/20499/#comment85799> For all of these calls to os::ls, why not call the result 'entries', then each loop can be: foreach (entry, entries) That should fit with our variable naming conventions as well (avoid abbreviations, camelCase). - Ben Mahler On July 28, 2014, 11:41 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20499/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 11:41 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1237 > https://issues.apache.org/jira/browse/MESOS-1237 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 08251724fbe45431db2c3637c6beec81f5744c4c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp > e916f027e1c9918ec4f2d41e03926c10a1080bca > 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp > cf2215a90d6e2673085293b8eaf5a44418da3bf0 > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > c5509632988401ee96ed2471c7278c8e164800d7 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 7fa7346346a33a05fbcd30a11053948eedba4764 > > Diff: https://reviews.apache.org/r/20499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
