> On July 29, 2014, 6:25 p.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1908 > > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1908> > > > > I agree that this flags isn't very Cpp style. > > > > Shouldn't be hard to break it up into two routines? one operates on > > eth0 and lo, the other vethX. 'update' calls both; 'cleanup' calls one? But > > I will leave it to you.
Yeah, i still prefer the existing way. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review49001 ----------------------------------------------------------- On July 29, 2014, 5:44 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 5:44 a.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Bugs: MESOS-1649 > https://issues.apache.org/jira/browse/MESOS-1649 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
