> On July 29, 2014, 12:55 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 2184-2186 > > <https://reviews.apache.org/r/24020/diff/1/?file=643992#file643992line2184> > > > > Seems this function is poorly named if it can optionally also remove > > filters on the veth? > > > > Do you need to explicitly remove filters off the veth, or can you just > > remove the bind mount and have the kernel clean that side up? > > > > - okay, I see it's used for update(). Seems to me this is mixing > > different functionality.
The 'Host' here means the filters are on the host side (versus on the container side). I am gonna ignore this comment for now. We can revisit that later. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review48952 ----------------------------------------------------------- On July 28, 2014, 11:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 11:53 p.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
