> On July 29, 2014, 12:24 a.m., Chi Zhang wrote: > > I think it is worth mentioning that we are doing this because _recover > > solely relies on the information on vethX so we want that port ranges on > > vethX are always more complete than those on eth0 or lo. > > > > also don't we need to loosen some checking for the ephemeral port in > > _recover as well?
Yes. I've updated the review. Please take a close look. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24020/#review48946 ----------------------------------------------------------- On July 29, 2014, 5:14 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24020/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 5:14 a.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > > Diff: https://reviews.apache.org/r/24020/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
