----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review49936 -----------------------------------------------------------
src/docker/docker.cpp <https://reviews.apache.org/r/24464/#comment87396> What if 'docker logs' fails? For example, the containerName is not valid? How are we gonna detect that? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24464/#comment87398> Who is gonna stop the log subprocess? Worth commenting on that? - Jie Yu On Aug. 7, 2014, 6:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 6:18 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Redirect docker logs > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
