----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50042 -----------------------------------------------------------
src/docker/docker.hpp <https://reviews.apache.org/r/24464/#comment87557> IMO, this function shouldn't set the future until the subprocess terminates. You may want to return checkError() here. See my comments below. You may also want to add a TODO here saying that consider using Subprocess::IO& to replace stdoutPath and stderrPath. src/docker/docker.cpp <https://reviews.apache.org/r/24464/#comment87558> return checkError(cmd, s.get()); src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24464/#comment87559> Since docker.logs won't set the future until it finishes (or failed), you can do this here: docker.logs(...) .onAny(defer(self(), &Self::_logs, ...); return Nothing(); Inside '_logs', you can do logging based on the returned future from docker.logs. - Jie Yu On Aug. 7, 2014, 9:56 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 9:56 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Redirect docker logs > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
