Yeah, you are right. Having a continuation to check the status is the right way.
On Fri, Aug 8, 2014 at 10:09 AM, Timothy Chen <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > > On August 8th, 2014, 4:41 p.m. UTC, *Jie Yu* wrote: > > src/docker/docker.cpp > <https://reviews.apache.org/r/24464/diff/2/?file=655523#file655523line512> > (Diff > revision 2) > > 512 > > return Nothing(); > > return checkError(cmd, s.get()); > > I don't think I want to checkError since it already reads stderr, however > docker logs pipes the stderr of the docker container to its process so I'll > end up re-reading the whole stderr of the container. > I think I'll just check status. > > > - Timothy > > On August 7th, 2014, 9:56 p.m. UTC, Timothy Chen wrote: > Review request for mesos and Benjamin Hindman. > By Timothy Chen. > > *Updated Aug. 7, 2014, 9:56 p.m.* > *Repository: * mesos-git > Description > > Redirect docker logs > > Testing > > make check > > Diffs > > - src/docker/docker.hpp (98b2d6099988f51f12e7b108e73dcfd0143adc48) > - src/docker/docker.cpp (1cba381118c6bd2ac7fcf5a8a229602e2c65c571) > - src/slave/containerizer/docker.cpp > (904cdd32362591777aecaa58e723af36419f011c) > > View Diff <https://reviews.apache.org/r/24464/diff/> >
