> On Aug. 8, 2014, 11:13 p.m., Jie Yu wrote: > > > > Timothy Chen wrote: > Ah sorry the docker tests passed, but I don't have tests in place for > testing the logs. I'll be adding some tests later.
Thanks Tim! > On Aug. 8, 2014, 11:13 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 411-416 > > <https://reviews.apache.org/r/24464/diff/4/?file=656753#file656753line411> > > > > Hum? Have you tested? > > > > if (!future.isReady()) {...} Also, instead of creating a msg here, just do LOG(INFO) << "" << """ << ...:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50085 ----------------------------------------------------------- On Aug. 8, 2014, 11:19 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 11:19 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24464 > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
