> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: > > Why did you need to mock DockerContainerizerProcess in order to write these > > tests? Couldn't you have just used the existing MockDockerContainerizer?
I wanted to simulate having destroy called in a pull/fetching state, so I thought the only way to do so is to mock the process since the callbacks are on DockerContainerizerProcess and not the Containerizer, so the callbacks for fetch and pull blocks and I can call destroy in that state and verify it was able to destroy. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review52758 ----------------------------------------------------------- On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24776/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 10:23 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Add docker containerizer destroy tests > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f > src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > > Diff: https://reviews.apache.org/r/24776/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
