> On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote: > > src/module/manager.cpp, lines 43-44 > > <https://reviews.apache.org/r/25848/diff/1/?file=697029#file697029line43> > > > > Ben, we did the module manager as a singleton. I know it is a uncommon > > pattern in Mesos in general. Do you have any thoughts on this? We will need > > to take care of thread-safety with whatever state we maintain in the module > > manager.
Ben, any thoughts on this one? - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54043 ----------------------------------------------------------- On Sept. 22, 2014, 8:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 8:22 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > include/mesos/module.hpp PRE-CREATION > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
