> On Sept. 24, 2014, 1:05 p.m., Timothy St. Clair wrote: > > I still debate whether we should name it "plugin" vs. "module". Thoughts?
Could be called either or, but think the term 'module' is pretty clear and is what we have gone with so far. I don't see any good reason to change it now unless anyone have some good references why it should be called 'plugins' (and not modules). +1 on your comments - threw in a couple of questions. > On Sept. 24, 2014, 1:05 p.m., Timothy St. Clair wrote: > > include/mesos/module.hpp, line 73 > > <https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73> > > > > Perhaps we can breakout in another JIRA, but I would to denote both > > some form of AUTHORING as well as define api's as EXPERIMENTAL. In another JIRA to discuss the format of the macros? Or what should the outcome be of the JIRA thread? +1 on having AUTHORING. How did you think about incorporating the experimentalness of the api? in the macro name? > On Sept. 24, 2014, 1:05 p.m., Timothy St. Clair wrote: > > src/module/manager.cpp, line 173 > > <https://reviews.apache.org/r/25848/diff/5/?file=701887#file701887line173> > > > > You could probably stick the json parsing into a separate sub-class. > > I'm all for breaking out a small JIRA tree from the comments. Is it so we can discuss the format further or because we should address this in different patches? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54425 ----------------------------------------------------------- On Sept. 22, 2014, 9:05 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 9:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > include/mesos/module.hpp PRE-CREATION > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
