----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54425 -----------------------------------------------------------
I still debate whether we should name it "plugin" vs. "module". Thoughts? include/mesos/module.hpp <https://reviews.apache.org/r/25848/#comment94563> If this is just for version information perhaps we can @VERSION@ replace, vs. including the whole protobuf header chain. include/mesos/module.hpp <https://reviews.apache.org/r/25848/#comment94564> Perhaps we can breakout in another JIRA, but I would to denote both some form of AUTHORING as well as define api's as EXPERIMENTAL. src/examples/test_module.hpp <https://reviews.apache.org/r/25848/#comment94565> +1 re: Adams comment. src/module/manager.hpp <https://reviews.apache.org/r/25848/#comment94569> If it's a singleton typically you can make the constructor protected/private such that it can never be instantiated externally. src/module/manager.hpp <https://reviews.apache.org/r/25848/#comment94571> can't we use std::mutex now? src/module/manager.cpp <https://reviews.apache.org/r/25848/#comment94572> same comment as above. src/module/manager.cpp <https://reviews.apache.org/r/25848/#comment94587> You could probably stick the json parsing into a separate sub-class. I'm all for breaking out a small JIRA tree from the comments. - Timothy St. Clair On Sept. 23, 2014, 4:05 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 4:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > include/mesos/module.hpp PRE-CREATION > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
