> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote: > > include/mesos/module.hpp, line 73 > > <https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73> > > > > Perhaps we can breakout in another JIRA, but I would to denote both > > some form of AUTHORING as well as define api's as EXPERIMENTAL. > > Niklas Nielsen wrote: > In another JIRA to discuss the format of the macros? Or what should the > outcome be of the JIRA thread? > > +1 on having AUTHORING. > > How did you think about incorporating the experimentalness of the api? in > the macro name?
re-experimental, we could probably just append to the end of the name with token pasting, but lets open up a separate JIRA for that. I figure this will take iterations. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54425 ----------------------------------------------------------- On Sept. 25, 2014, 12:11 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 12:11 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > configure.ac da61c2984bac378d5298b781476da4f0c20375d1 > include/mesos/module.hpp.in PRE-CREATION > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
