----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55232 -----------------------------------------------------------
src/slave/flags.hpp <https://reviews.apache.org/r/26275/#comment95627> we put the initializer list on the next line. src/slave/flags.hpp <https://reviews.apache.org/r/26275/#comment95629> Can you send an email to the dev list indicating this change? If people object to this change landing in 0.21.0 without deprecation warning, we might have to kill it in 0.22.0 with a warning in 0.21.0. src/slave/flags.hpp <https://reviews.apache.org/r/26275/#comment95628> Can you add a comment here mentioning why the field is here though there is no corresponding add? - Vinod Kone On Oct. 2, 2014, 6:44 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26275/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 6:44 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-444 > https://issues.apache.org/jira/browse/MESOS-444 > > > Repository: mesos-git > > > Description > ------- > > Checkpointing has been enabled by default in the slave since 0.14, remove the > flag now because all slaves should checkpoint. > > Removing checkpoint from slaves throughout the codebase will occur in a > series of following commits. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > > Diff: https://reviews.apache.org/r/26275/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 with gcc. > > > Thanks, > > Cody Maloney > >
