> On Oct. 2, 2014, 7:28 p.m., Dominic Hamon wrote: > > src/slave/flags.hpp, line 348 > > <https://reviews.apache.org/r/26275/diff/2/?file=711514#file711514line348> > > > > consider making this const to indicate it is no longer mutable through > > flags.
There is manual setting of this in a number of the unit tests, so it can't be const here yet. In the next patch which I've been working on I remove this variable entirely from flags (Leaving the checkpoint variable in the SlaveInfo struct). - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55233 ----------------------------------------------------------- On Oct. 2, 2014, 7:25 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26275/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-444 > https://issues.apache.org/jira/browse/MESOS-444 > > > Repository: mesos-git > > > Description > ------- > > Checkpointing has been enabled by default in the slave since 0.14, remove the > flag now because all slaves should checkpoint. > > Removing checkpoint from slaves throughout the codebase will occur in a > series of following commits. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > > Diff: https://reviews.apache.org/r/26275/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 with gcc. > > > Thanks, > > Cody Maloney > >
