----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55543 -----------------------------------------------------------
Ship it! minor fixes and we will get this committed. src/slave/flags.hpp <https://reviews.apache.org/r/26275/#comment95911> Indent by 2 spaces not 4. src/slave/flags.hpp <https://reviews.apache.org/r/26275/#comment95912> I don't it's that clear what "No add..." means. Just say "See MESOS-444 for more details." on line #338. - Vinod Kone On Oct. 2, 2014, 7:25 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26275/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-444 > https://issues.apache.org/jira/browse/MESOS-444 > > > Repository: mesos-git > > > Description > ------- > > Checkpointing has been enabled by default in the slave since 0.14, remove the > flag now because all slaves should checkpoint. > > Removing checkpoint from slaves throughout the codebase will occur in a > series of following commits. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > > Diff: https://reviews.apache.org/r/26275/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 with gcc. > > > Thanks, > > Cody Maloney > >
